A professional singer is someone who supports his/her life by singing.
Let’s not get bogged down with quality control. To make a career is the point, and, if one does that, then the possessor of that career is a professional. If you think there should be some qualitative distinctions, see “Traditional Expectations” to have a look at what Quantz had to say about a “Good Singer”.